[stable11] LDAP's checkPassword should only catch when a user was not found #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2431 Also fixes error processing after ldap_search, due to different return format Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
requested review from
ChristophWurst,
LukasReschke,
nickvergessen and
oparoz
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @Xenopathic to be potential reviewers. |
Member
Author
|
summoning @nextcloud/ldap :) |
Member
|
please backport 👍 |
LukasReschke
approved these changes
Feb 16, 2017
Member
|
💃👯👯👯💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3324 fixes #2431 (at least partly for LDAP users)
Would be good to get it into today's RC 2
@karlitschek backport granted?